Skip to content

HDFS-16321. Fix invalid config in TestAvailableSpaceRackFaultTolerantBPP #3655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ayushtkn merged 10 commits into from
Nov 14, 2021
Merged

HDFS-16321. Fix invalid config in TestAvailableSpaceRackFaultTolerantBPP #3655

Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3c51579
Merge pull request #1 from apache/trunk
GuoPhilipse Nov 29, 2020
a449d04
Merge pull request #2 from apache/trunk
GuoPhilipse Dec 12, 2020
d4f968b
Merge pull request #3 from apache/trunk
GuoPhilipse Apr 7, 2021
d522abf
Merge pull request #4 from apache/trunk
GuoPhilipse Apr 21, 2021
de633b8
Merge pull request #5 from apache/trunk
GuoPhilipse Oct 16, 2021
66ce06b
Merge pull request #6 from apache/trunk
GuoPhilipse Nov 8, 2021
23c45ee
fixinvalidconfig
GuoPhilipse Nov 13, 2021
d501c0e
fixinvalidconfig
GuoPhilipse Nov 13, 2021
b881916
fixinvalidconfig
GuoPhilipse Nov 13, 2021
dcc21b4
triggerrebuild
GuoPhilipse Nov 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...org/apache/hadoop/hdfs/server/blockmanagement/TestAvailableSpaceRackFaultTolerantBPP.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public class TestAvailableSpaceRackFaultTolerantBPP {
public static void setupCluster() throws Exception {
conf = new HdfsConfiguration();
conf.setFloat(
DFSConfigKeys.DFS_NAMENODE_AVAILABLE_SPACE_BLOCK_PLACEMENT_POLICY_BALANCED_SPACE_PREFERENCE_FRACTION_KEY,
DFSConfigKeys.DFS_NAMENODE_AVAILABLE_SPACE_RACK_FAULT_TOLERANT_BLOCK_PLACEMENT_POLICY_BALANCED_SPACE_PREFERENCE_FRACTION_KEY,
0.6f);
String[] racks = new String[NUM_RACKS];
for (int i = 0; i < NUM_RACKS; i++) {
Expand Down Expand Up @@ -189,6 +189,13 @@ public void testChooseDataNode() {
}
}

@Test
public void testDefaultConfigValue() {
Assert.assertEquals(
conf.get("DFS_NAMENODE_AVAILABLE_SPACE_RACK_FAULT_TOLERANT_BLOCK_PLACEMENT_POLICY_BALANCED_SPACE_PREFERENCE_FRACTION_KEY")
,0.6f);
}

Copy link
Member

@ayushtkn ayushtkn Nov 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't required, this isn't checking the BPP, but how the conf object works. you can remove this test.

Copy link
Member Author

@GuoPhilipse GuoPhilipse Nov 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't required, this isn't checking the BPP, but how the conf object works. you can remove this test.

Thanks @ayushtkn for your review. I have removed the test case, but not sure if the CI will pass if no tests added. hope it works.

/**
* Test if the nodes are all spread across all racks.
*/
Expand Down