Skip to content

HDFS-15927. Catch polymorphic type by reference #2824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
goiri merged 1 commit into from
Mar 30, 2021
Merged

HDFS-15927. Catch polymorphic type by reference #2824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ject/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/common/hdfs_configuration.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ std::vector<NamenodeInfo> HdfsConfiguration::LookupNameService(const std::string
URI uri;
try {
uri = URI::parse_from_string(PrependHdfsScheme(Get(dom_node_name)));
} catch (const uri_parse_error) {
} catch (const uri_parse_error&) {
throw ha_parse_error("unable to find " + dom_node_name);
}

Expand All @@ -148,7 +148,7 @@ std::vector<NamenodeInfo> HdfsConfiguration::LookupNameService(const std::string
NamenodeInfo node(nameservice, *node_id, uri);
namenodes.push_back(node);
}
} catch (ha_parse_error e) {
} catch (const ha_parse_error& e) {
LOG_ERROR(kRPC, << "HA cluster detected but failed because : " << e.what());
namenodes.clear(); // Don't return inconsistent view
}
Expand Down