-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-17305 Fix ITestCustomSigner to work with s3 compatible endpoints #2395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
change makes sense to me, we don't need to have this specific client created here. |
bgaborg
approved these changes
Oct 21, 2020
Contributor
|
oops, merged before yetus. Let's see what happens and whether I should revert. Yetus isn't going to run this test anyway |
Contributor
|
having problems with this and a bucket in ireland where I haven't fixed the endpoint up This is in #2778 but I've just replicated it in trunk too. |
steveloughran
pushed a commit
to steveloughran/hadoop
that referenced
this pull request
Mar 24, 2021
…nts (apache#2395) Contributed by Mukund Thakur
asfgit
pushed a commit
that referenced
this pull request
Mar 25, 2021
…nts (#2395) Contributed by Mukund Thakur Change-Id: Ia5def405056691c349cf05530fd3172047d2058b
jojochuang
pushed a commit
to jojochuang/hadoop
that referenced
this pull request
May 23, 2023
…nts (apache#2395) Contributed by Mukund Thakur Change-Id: Ib8dd09b69ce68d6cc8cb6c1cb09d755992483ee4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re ran the failing test with s3 and gcs endpoints. All good.