HDFS-15500. In-order deletion of snapshots: Diff lists must be update only in the last snapshot

[szetszwo]

See https://issues.apache.org/jira/browse/HDFS-15500

[hadoop-yetus]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	31m 47s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1 💚	mvninstall	28m 50s	trunk passed
+1 💚	compile	1m 17s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	1m 9s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	checkstyle	0m 52s	trunk passed
+1 💚	mvnsite	1m 20s	trunk passed
+1 💚	shadedclient	16m 13s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 50s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	1m 26s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗	spotbugs	2m 58s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 56s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 12s	the patch passed
+1 💚	compile	1m 7s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	1m 7s	the patch passed
+1 💚	compile	1m 1s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	javac	1m 1s	the patch passed
-0 ⚠️	checkstyle	0m 43s	hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 185 unchanged - 0 fixed = 186 total (was 185)
+1 💚	mvnsite	1m 8s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	2m 30s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 43s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	1m 18s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	findbugs	2m 58s	the patch passed
		_ Other Tests _
-1 ❌	unit	133m 39s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 39s	The patch does not generate ASF License warnings.
		235m 18s

Reason	Tests
Failed junit tests	hadoop.hdfs.TestFileChecksumCompositeCrc
	hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
	hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
	hadoop.hdfs.TestErasureCodingPolicyWithSnapshotWithRandomECPolicy
	hadoop.hdfs.TestDFSStripedOutputStream
	hadoop.hdfs.TestReadStripedFileWithMissingBlocks
	hadoop.hdfs.TestEncryptionZonesWithKMS

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2233/1/artifact/out/Dockerfile
GITHUB PR	#2233
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux fb60895c474a 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 9b9f7ea
Default Java	Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
checkstyle	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2233/1/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
unit	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2233/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2233/1/testReport/
Max. process+thread count	3644 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2233/1/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

[bshashikant]

@szetszwo , can you take care of the checkstyle issue?

[szetszwo]

./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:1574: assert assertsEnabled = true; // Intentional side effect!!!:27: Inner assignments should be avoided. [InnerAssignment]

@bshashikant The checkstyle issue is intentional as stated in the comment. That is the way to check if assert is enabled in the code.