Skip to content

HADOOP-16998 WASB : NativeAzureFsOutputStream#close() throwing java.l… #2073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steveloughran merged 6 commits into from
Jul 14, 2020
Merged

HADOOP-16998 WASB : NativeAzureFsOutputStream#close() throwing java.l… #2073

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
717c870
HADOOP-16998 WASB : NativeAzureFsOutputStream#close() throwing java.l…
anoopsjohn Jun 13, 2020
b021879
HADOOP-16998 WASB : NativeAzureFsOutputStream#close() throwing java.l…
anoopsjohn Jun 21, 2020
570eca1
HADOOP-16998 WASB : NativeAzureFsOutputStream#close() throwing java.l…
anoopsjohn Jun 21, 2020
fa29d02
HADOOP-16998 WASB : NativeAzureFsOutputStream#close() throwing java.l…
anoopsjohn Jun 22, 2020
d72aa7e
HADOOP-16998 WASB : NativeAzureFsOutputStream#close() throwing java.l…
anoopsjohn Jul 7, 2020
e0a8551
Update TestSyncableDataOutputStream.java
steveloughran Jul 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/SyncableDataOutputStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,13 @@
import java.io.IOException;
import java.io.OutputStream;

import org.apache.hadoop.classification.InterfaceAudience;
import org.apache.hadoop.fs.StreamCapabilities;
import org.apache.hadoop.fs.Syncable;
import org.slf4j.Logger;
Copy link
Contributor

@steveloughran steveloughran Jun 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put in an import block just above the org.apache one. I know a lot of classes don't do that -but that is because the move from o.a.commons.logging to SLF4J was done with 'sed'

Copy link
Contributor Author

@anoopsjohn anoopsjohn Jun 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
org.apache.hadoop.classification.InterfaceAudience was wrongly placed. Corrected it now.

Copy link
Contributor

@steveloughran steveloughran Jun 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, i meant "org.slf4j to go into a block above the org.apache one", below the java. one...its where we like keep the non-apache, non-static imports

import org.slf4j.LoggerFactory;

import org.apache.hadoop.fs.StreamCapabilities;
import org.apache.hadoop.fs.Syncable;
import org.apache.hadoop.classification.InterfaceAudience;
Copy link
Contributor

@steveloughran steveloughran Jun 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are getting so close here. Now move this up to L28.

Copy link
Contributor Author

@anoopsjohn anoopsjohn Jun 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean move to L27 so that org.slf4j and org.apche are single block?

Copy link
Contributor Author

@anoopsjohn anoopsjohn Jun 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry Steve am not getting fully.
So you say move this entire org.apache block to L27 (So that new new line between org.slf4j and org.apache block)
Or u want to move import org.apache.hadoop.classification.InterfaceAudience; (In L30) to L28 so that within org.apache block things are properly imported in order and still keep this org.apache and org.slf as 2 blocks.


/**
* Support the Syncable interface on top of a DataOutputStream.
* This allows passing the sync/hflush/hsync calls through to the
Expand Down
1 change: 1 addition & 0 deletions ...s/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestSyncableDataOutputStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import java.io.OutputStream;

import org.apache.hadoop.test.LambdaTestUtils;

import org.junit.Test;
Copy link
Contributor

@steveloughran steveloughran Jun 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, org.junit to a (new) "non org.apache imports' block

Copy link
Contributor Author

@anoopsjohn anoopsjohn Jun 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Steve for explaining..
Sorry I did the organize import at eclipse level and just used the same import formatter what using for hbase.
Did the 2 import order changes as u suggested and pushed.


public class TestSyncableDataOutputStream {
Expand Down