Skip to content

HADOOP-16888. [JDK11] Support JDK11 in the precommit job #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aajisaka merged 10 commits into from
Jun 19, 2020
Merged

HADOOP-16888. [JDK11] Support JDK11 in the precommit job #2012

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1cad9ef
Refactor Dockerfile
aajisaka May 12, 2020
fc7d9e6
Add Java 11 test in GitHub PR
aajisaka May 12, 2020
1862abd
Correct the order
aajisaka May 12, 2020
2752cdb
Set Java home to JDK 8 explicitly
aajisaka May 12, 2020
11558af
Increase the timeout
aajisaka May 13, 2020
c6de145
Increase the timeout to 24 hours.
aajisaka May 18, 2020
9a3526c
Stop running unit tests in Java 11.
aajisaka May 19, 2020
cb289d0
Increase timeout
aajisaka May 20, 2020
7a4aba6
Set timeout to 20 hours.
aajisaka May 24, 2020
8cb30d1
Revert the timeout change
aajisaka Jun 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ pipeline {

options {
buildDiscarder(logRotator(numToKeepStr: '5'))
timeout (time: 5, unit: 'HOURS')
timeout (time: 20, unit: 'HOURS')
timestamps()
checkoutToSubdirectory('src')
}
Expand Down Expand Up @@ -154,6 +154,11 @@ pipeline {
# use emoji vote so it is easier to find the broken line
YETUS_ARGS+=("--github-use-emoji-vote")

# test with Java 8 and 11
YETUS_ARGS+=("--java-home=/usr/lib/jvm/java-8-openjdk-amd64")
YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-11-openjdk-amd64")
YETUS_ARGS+=("--multijdktests=compile")

"${TESTPATCHBIN}" "${YETUS_ARGS[@]}"
'''
}
Expand Down
53 changes: 13 additions & 40 deletions dev-support/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,10 @@ RUN echo APT::Install-Suggests "0"\; >> /etc/apt/apt.conf.d/10disableextras
ENV DEBIAN_FRONTEND noninteractive
ENV DEBCONF_TERSE true

######
# Install common dependencies from packages. Versions here are either
# sufficient or irrelevant.
#
# WARNING: DO NOT PUT JAVA APPS HERE! Otherwise they will install default
# Ubuntu Java. See Java section below!
######
# hadolint ignore=DL3008
RUN apt-get -q update \
&& apt-get -q install -y --no-install-recommends \
ant \
apt-utils \
bats \
build-essential \
Expand All @@ -51,11 +45,13 @@ RUN apt-get -q update \
cmake \
curl \
doxygen \
findbugs \
fuse \
g++ \
gcc \
git \
gnupg-agent \
libbcprov-java \
libbz2-dev \
libcurl4-openssl-dev \
libfuse-dev \
Expand All @@ -64,11 +60,13 @@ RUN apt-get -q update \
libsasl2-dev \
libsnappy-dev \
libssl-dev \
libsnappy-dev \
libtool \
libzstd1-dev \
locales \
make \
maven \
openjdk-11-jdk \
openjdk-8-jdk \
pinentry-curses \
pkg-config \
python \
Expand All @@ -86,15 +84,13 @@ RUN apt-get -q update \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*


#######
# OpenJDK 8
#######
# hadolint ignore=DL3008
RUN apt-get -q update \
&& apt-get -q install -y --no-install-recommends openjdk-8-jdk libbcprov-java \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*
######
# Set env vars required to build Hadoop
######
ENV MAVEN_HOME /usr
# JAVA_HOME must be set in Maven >= 3.5.0 (MNG-6003)
ENV JAVA_HOME /usr/lib/jvm/java-8-openjdk-amd64
ENV FINDBUGS_HOME /usr

######
# Install Google Protobuf 3.7.1 (3.0.0 ships with Bionic)
Expand All @@ -113,29 +109,6 @@ RUN mkdir -p /opt/protobuf-src \
ENV PROTOBUF_HOME /opt/protobuf
ENV PATH "${PATH}:/opt/protobuf/bin"

######
# Install Apache Maven 3.6.0 (3.6.0 ships with Bionic)
######
# hadolint ignore=DL3008
RUN apt-get -q update \
&& apt-get -q install -y --no-install-recommends maven \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*
ENV MAVEN_HOME /usr
# JAVA_HOME must be set in Maven >= 3.5.0 (MNG-6003)
ENV JAVA_HOME /usr/lib/jvm/java-8-openjdk-amd64

######
# Install findbugs 3.1.0 (3.1.0 ships with Bionic)
# Ant is needed for findbugs
######
# hadolint ignore=DL3008
RUN apt-get -q update \
&& apt-get -q install -y --no-install-recommends findbugs ant \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*
ENV FINDBUGS_HOME /usr

####
# Install pylint at fixed version (2.0.0 removed python2 support)
# https://github.com/PyCQA/pylint/issues/2294
Expand Down