Skip to content

HDDS-1783 : Latency metric for applyTransaction in ContainerStateMach… #1363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bshashikant merged 6 commits into from
Sep 3, 2019
Merged

HDDS-1783 : Latency metric for applyTransaction in ContainerStateMach… #1363

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3a009e9
HDDS-1783 : Latency metric for applyTransaction in ContainerStateMach…
Aug 28, 2019
643eb4b
HDDS-1783 : Latency metric for applyTransaction in ContainerStateMach…
Aug 28, 2019
9bdbea3
HDDS-1783 : Latency metric for applyTransaction in ContainerStateMach…
Aug 28, 2019
6d82c08
HDDS-1783 : Latency metric for applyTransaction in ContainerStateMach…
Aug 29, 2019
944c690
Merge remote-tracking branch 'upstream/trunk' into HDDS-1783-trunk
Aug 29, 2019
d567fe4
HDDS-1783 : Latency metric for applyTransaction in ContainerStateMach…
Aug 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/CSMMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ public class CSMMetrics {
private @Metric MutableCounterLong numStartTransactionVerifyFailures;
private @Metric MutableCounterLong numContainerNotOpenVerifyFailures;

private @Metric MutableRate applyTransactionLatency;

public CSMMetrics() {
int numCmdTypes = ContainerProtos.Type.values().length;
this.opsLatency = new MutableRate[numCmdTypes];
Expand Down Expand Up @@ -181,6 +183,11 @@ public long getNumBytesCommittedCount() {
return numBytesCommittedCount.value();
}

@VisibleForTesting
public MutableRate getApplyTransactionLatency() {
return applyTransactionLatency;
}

public void incPipelineLatency(ContainerProtos.Type type, long latencyNanos) {
opsLatency[type.ordinal()].add(latencyNanos);
transactionLatency.add(latencyNanos);
Expand All @@ -194,6 +201,9 @@ public void incNumContainerNotOpenVerifyFailures() {
numContainerNotOpenVerifyFailures.incr();
}

public void recordApplyTransactionLatency(long latencyNanos) {
applyTransactionLatency.add(latencyNanos);
}

public void unRegister() {
MetricsSystem ms = DefaultMetricsSystem.instance();
Expand Down
7 changes: 6 additions & 1 deletion ...rg/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,6 +665,7 @@ public CompletableFuture<Message> applyTransaction(TransactionContext trx) {
.setTerm(trx.getLogEntry().getTerm())
.setLogIndex(index);

long applyTxnStartTime = Time.monotonicNowNanos();
try {
applyTransactionSemaphore.acquire();
metrics.incNumApplyTransactionsOps();
Expand Down Expand Up @@ -732,7 +733,11 @@ public CompletableFuture<Message> applyTransaction(TransactionContext trx) {
}
}
return applyTransactionFuture;
}).whenComplete((r, t) -> applyTransactionSemaphore.release());
}).whenComplete((r, t) -> {
applyTransactionSemaphore.release();
metrics.recordApplyTransactionLatency(
Time.monotonicNowNanos() - applyTxnStartTime);
});
return applyTransactionFuture;
} catch (IOException | InterruptedException e) {
metrics.incNumApplyTransactionsFails();
Expand Down