HDDS-1813. Fix false warning from ozones3 acceptance test. Contribute…#1107
Merged
Conversation
bharatviswa504
approved these changes
Jul 16, 2019
Contributor
There was a problem hiding this comment.
+1 LGTM.
Me too seen this issue in acceptance run test results but never thought this is a space issue.
Thank You @xiaoyuyao for the fix.
|
💔 -1 overall
This message was automatically generated. |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
… only During startup, the CSM cleans up the base directories for stores. Ideally, this cleanup should only be done for non-logged stores. In our current setup, if the applications configure both logged and non-logged store base directories to be the same, we delete the logged store directories as well which results in unnecessary bootstrap. In this PR, * We modify the clean up behavior on startup to impact only non-logged stores * Update the configuration documentation to reflect potential implications of not configuring `job.logged.store.base.dir` and `job.non.logged.store.base.dir` for stateful applications. * Add a warning if both logged and non-logged store base directories are configured to use same path. Author: mynameborat <[email protected]> Reviewers: Hai Lu <[email protected]> Closes apache#1107 from mynameborat/SAMZA-2274 and squashes the following commits: 7d47a90b [mynameborat] Fix the logged store condition check 35b1bb3d [mynameborat] Cleanup store directories on startup for non-logged store only
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
…d by Xiaoyu Yao. (apache#1107)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…d by Xiaoyu Yao.