HADOOP-13320. Fix arguments check in the WordCount v2.0 in Documentation #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibuted by Niccolo Becchi
Contributor
|
Looks like the right fix, but can you simplify the logic a little, i.e. (len != 2) && (len != 4)? |
…he logic a little
Author
|
Thanks @templedf I have updated the pull request following the suggestion |
shanthoosh
added a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
Changes: * Moved all states locally within the test methods(no global state, since tests can be run parallely). * Increased the timeout waiting for all task threads to finish. * Changed message chooser mock to return null at the end(When EOS message is used a final msg, during some runs task.process gets invoked more than once for it. This is due to test setup, other tests within this test class also do the same.) How was it verified: Ran the test class repeatedly to check for failures(there were none) using following script. ` while [ $i -lt 30 ] do sleep 3; i=`expr $i + 1`; ./gradlew :samza-core:clean :samza-core:test -Dtest.single=TestAsyncRunLoop done ` Author: Shanthoosh Venkataraman <[email protected]> Reviewers: Xinyu Liu <[email protected]> Closes apache#108 from shanthoosh/fix-async-run-loop-tests-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.