Skip to content

[FLINK-22396][legal] Remove unnecessary entries from sql hbase connector NOTICE file #15706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dawidwys wants to merge 2 commits into from
Closed

[FLINK-22396][legal] Remove unnecessary entries from sql hbase connector NOTICE file #15706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd3f3cd
[FLINK-22396][legal] Remove unnecessary entries from sql hbase connec…
dawidwys Apr 21, 2021
e89b50c
[FLINK-22396][hbase] Remove unnecessary entries from shaded plugin co…
dawidwys Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions flink-connectors/flink-sql-connector-hbase-1.4/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,14 +79,10 @@ under the License.
<include>com.yammer.metrics:metrics-core</include>
<include>commons-logging:commons-logging</include>
<include>commons-lang:commons-lang</include>
<include>commons-configuration:commons-configuration</include>
<include>commons-codec:commons-codec</include>
<include>io.netty:netty-all</include>
</includes>
<excludes>
<exclude>org.apache.hbase:hbase-metrics*</exclude>
<exclude>org.apache.hbase:hbase-server*</exclude>
<exclude>org.apache.hbase:hbase-hadoop*-compat</exclude>
<exclude>org.apache.hbase:hbase-common:jar:tests</exclude>
</excludes>
</artifactSet>
Expand Down
3 changes: 0 additions & 3 deletions flink-connectors/flink-sql-connector-hbase-1.4/src/main/resources/META-INF/NOTICE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,11 @@ This project bundles the following dependencies under the Apache Software Licens
- com.google.guava:guava:12.0.1
- com.yammer.metrics:metrics-core:2.2.0
- commons-codec:commons-codec:1.13
- commons-configuration:commons-configuration:1.7
Copy link
Contributor

@zentol zentol Apr 21, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the shade plugin contains an explicit include for this dependency, which should also be removed

Copy link
Contributor Author

@dawidwys dawidwys Apr 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Missed it. Fixing.

- commons-lang:commons-lang:2.6
- commons-logging:commons-logging:1.1.3
- io.netty:netty-all:4.1.46.Final
- org.apache.hbase:hbase-client:1.4.3
- org.apache.hbase:hbase-common:1.4.3
- org.apache.hbase:hbase-prefix-tree:1.4.3
- org.apache.hbase:hbase-procedure:1.4.3
- org.apache.hbase:hbase-protocol:1.4.3
- org.apache.htrace:htrace-core:3.1.0-incubating
- org.apache.zookeeper:zookeeper:3.4.14
Expand Down