Skip to content

[FLINK-37152][build] Update Flink version to 1.20 #3868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
leonardBang merged 1 commit into from
Feb 20, 2025
Merged

[FLINK-37152][build] Update Flink version to 1.20 #3868

leonardBang merged 1 commit into from
Feb 20, 2025

Conversation

@ferenc-csaky
Copy link
Contributor

@ferenc-csaky ferenc-csaky commented Jan 16, 2025

No description provided.

@ferenc-csaky
Copy link
Contributor Author

ferenc-csaky commented Jan 16, 2025

The mongodb7 CI failure is interesting, cause it ran without problem locally (on macOS). The test times out, I'm just downloading the logs, will check it out.

@lvyanquan
Copy link
Contributor

lvyanquan commented Feb 18, 2025 •
edited
Loading

The mongodb7 CI failure is interesting, cause it ran without problem locally (on macOS). The test times out, I'm just downloading the logs, will check it out.

Hi @ferenc-csaky, have you found out the cause, or is it just an accidental failure?

@ferenc-csaky ferenc-csaky force-pushed the FLINK-37152 branch 2 times, most recently from aec0014 to d2189d7 Compare February 18, 2025 12:02
@github-actions github-actions bot added the docs Improvements or additions to documentation label Feb 18, 2025
@ferenc-csaky
Copy link
Contributor Author

ferenc-csaky commented Feb 18, 2025 •
edited
Loading

@lvyanquan seemed to be some intermittent issue, the CI I ran today succeeded at that step, but since in the meantime Flink 1.20.1 got released IMO it makes sense to update to that right away, so I updated 1.20.0 to 1.20.1 in all relevant places, except the CI.

After I saw that updating the patch version affects the doc build, I quickly reconsidered my previous plan and since at one pont 1.19.0 has to be updated anyway it probably easier to keep this change as minimal as possible.

@github-actions github-actions bot removed the docs Improvements or additions to documentation label Feb 18, 2025
@ferenc-csaky
Copy link
Contributor Author

ferenc-csaky commented Feb 18, 2025

Well, exchanged the mongodb7 failure to a mysql one.. :) Will check on it tomorrow

@lvyanquan
Copy link
Contributor

lvyanquan commented Feb 19, 2025

Well, exchanged the mongodb7 failure to a mysql one.. :) Will check on it tomorrow

I think that the failure of mysql is unrelated to the change here, because this error also occurs on the master branch, I will also try to identify the cause of this problem.

lvyanquan
lvyanquan approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@lvyanquan lvyanquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

leonardBang
leonardBang reviewed Feb 20, 2025
View reviewed changes
pom.xml
<!-- dependencies versions -->
<flink.version>1.19.1</flink.version>
<flink.major.version>1.19</flink.major.version>
<flink.version>1.20.0</flink.version>
Copy link
Contributor

@leonardBang leonardBang Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ferenc-csaky Could you bump this version to 1.20.1 as we just released it?

Copy link
Contributor Author

@ferenc-csaky ferenc-csaky Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was my original idea as well, but that generated more and more changes (docs, CI, etc), and 1.19.1 has to be bumped to 1.19.2 as well anyways. I'm happy to update both patch versions in a follow-up PR in 1 chunk. WDYT?

Copy link
Contributor

@leonardBang leonardBang Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As they're hotfix versions, follow-up PR makes sense to me, thanks for your quick response.

@leonardBang
Copy link
Contributor

leonardBang commented Feb 20, 2025

Well, exchanged the mongodb7 failure to a mysql one.. :) Will check on it tomorrow

It's a known issue, maybe related to polardbx docker image, I've connected with the polardbx feature contributor, and he will look into this failure, FYI

@leonardBang leonardBang merged commit 0211a13 into apache:master Feb 20, 2025
30 of 31 checks passed
@leonardBang
Copy link
Contributor

leonardBang commented Feb 20, 2025

Failed case tracked via https://issues.apache.org/jira/browse/FLINK-37362

@ferenc-csaky ferenc-csaky deleted the FLINK-37152 branch February 20, 2025 13:30
SML0127 pushed a commit to SML0127/flink-cdc-connectors that referenced this pull request Feb 21, 2025
@ferenc-csaky
[FLINK-37152][build] Update Flink version to 1.20
580b950 
This closes  apache#3868.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leonardBang leonardBang leonardBang approved these changes

@lvyanquan lvyanquan lvyanquan approved these changes

Assignees

No one assigned

Labels

approved build cli e2e-tests mongodb-cdc-connector mysql-cdc-connector oceanbase-cdc-connector postgres-cdc-connector reviewed runtime sqlserver-cdc-connector starrocks-pipeline-connector tidb-cdc-connector vitess-cdc-connector

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ferenc-csaky @lvyanquan @leonardBang