Support parsing custom REST paths from proto files and generating @Ma…#14796
Merged
oxsean merged 13 commits intoapache:3.3from Nov 3, 2024
Merged
Support parsing custom REST paths from proto files and generating @Ma…#14796oxsean merged 13 commits intoapache:3.3from
oxsean merged 13 commits intoapache:3.3from
Conversation
oxsean
requested changes
Oct 30, 2024
dubbo-plugin/dubbo-compiler/pom.xml
Outdated
| <groupId>com.salesforce.servicelibs</groupId> | ||
| <artifactId>grpc-contrib</artifactId> | ||
| </dependency> | ||
| <dependency> |
Contributor
There was a problem hiding this comment.
Do we need this module just to generate code?
| } | ||
|
|
||
| if (!httpRule.getGet().isEmpty()) { | ||
| methodContext.path = httpRule.getGet(); |
Contributor
There was a problem hiding this comment.
Can it be mege with line 199?
|
|
||
| {{#packageName}} | ||
| package {{packageName}}; | ||
| package {{packageName}}; |
| CompletableFuture<{{outputType}}> {{methodName}}Async({{inputType}} request); | ||
|
|
||
| {{#hasMappings}} | ||
| @Mapping(method = HttpMethods.{{httpMethod}}, path = "{{path}}") |
Contributor
There was a problem hiding this comment.
Try to make sure that the indents of the generated code is correct.
| @Target(ElementType.PARAMETER) | ||
| @Retention(RetentionPolicy.RUNTIME) | ||
| @Documented | ||
| public @interface Grequest { |
| import java.util.Map; | ||
|
|
||
| @Activate | ||
| public class GrpcBodyArgumentResolver implements AnnotationBaseArgumentResolver<Grequest> { |
Contributor
There was a problem hiding this comment.
Rename to GRequestArgumentResolver
| public String javaDoc; | ||
| public HttpMethods httpMethod; | ||
| public String path; | ||
| public String body; // requestBody |
Contributor
There was a problem hiding this comment.
Make the comments readable
e.g.: Specify the message field that the HTTP request body mapping to
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
Support parsing custom REST paths from proto files and generating
@Mappingannotations. #13369Checklist