Skip to content

Conversation

@finefuture
Copy link
Contributor

What is the purpose of the change

Add registry info to notify message.
For example:
image

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Comment on lines 342 to 344
"Invokers Size : " + getInvokers().size() + ". " +
"Available Size: " + getValidInvokers().size() + ". " +
"Available Invokers : " + joinValidInvokerAddresses());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove these lines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recovered, For example:
image

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.40%. Comparing base (8b0bd8a) to head (2c89097).
Report is 593 commits behind head on 3.2.

Current head 2c89097 differs from pull request most recent head 4866c6e

Please upload reports for the commit 4866c6e to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.2   #13172      +/-   ##
============================================
- Coverage     69.44%   69.40%   -0.04%     
  Complexity        2        2              
============================================
  Files          1648     1648              
  Lines         68688    68685       -3     
  Branches      10014    10014              
============================================
- Hits          47697    47668      -29     
- Misses        16399    16433      +34     
+ Partials       4592     4584       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@finefuture finefuture requested a review from AlbumenJ October 9, 2023 12:46
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AlbumenJ AlbumenJ merged commit a45f50d into apache:3.2 Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants