Skip to content

Conversation

@finefuture
Copy link
Contributor

What is the purpose of the change

Only judge true isn't accurate

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #12876 (c0fcf15) into 3.2 (45405ff) will increase coverage by 0.73%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##                3.2   #12876       +/-   ##
=============================================
+ Coverage     68.77%   69.50%    +0.73%     
+ Complexity      318        2      -316     
=============================================
  Files          3657     1648     -2009     
  Lines        170962    68371   -102591     
  Branches      28310     9989    -18321     
=============================================
- Hits         117573    47520    -70053     
+ Misses        43258    16274    -26984     
+ Partials      10131     4577     -5554     

see 2043 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ merged commit 1c48ba2 into apache:3.2 Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants