remove spring default qos-enable

[xixingya]

What is the purpose of the change

fix #12779

Brief changelog

Verifying this change

Checklist

• Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
• Each commit in the pull request should have a meaningful subject line and body.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
• Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
• Add some description to dubbo-website project if you are requesting to add a feature.
• GitHub Actions works fine on your own branch.
• If this contribution is large, please follow the Software Donation Guide.

[xixingya]

fix #12779 make this propertis load first so that spring boot default config will not configed

[AlbumenJ]

In order to fix #12779, we should remove the hard code of qos-enable=true when parsing spring proeprties.

[xixingya]

In order to fix #12779, we should remove the hard code of qos-enable=true when parsing spring proeprties.

But where can we set default true value when user doesn't set qos-enable

[xixingya]

In order to fix #12779, we should remove the hard code of qos-enable=true when parsing spring proeprties.

if we let dubbo.properties load before application.yml，the default value will not set

[AlbumenJ]

In order to fix #12779, we should remove the hard code of qos-enable=true when parsing spring proeprties.

if we let dubbo.properties load before application.yml，the default value will not set

This is a breaking change, and if it can only fix qos-enable is not worthable. We should fix it in application.yml.

[AlbumenJ]

org.apache.dubbo.spring.boot.env.DubboDefaultPropertiesEnvironmentPostProcessor#createDefaultProperties

[AlbumenJ]

org.apache.dubbo.spring.boot.env.DubboDefaultPropertiesEnvironmentPostProcessor#createDefaultProperties

Remove setDubboApplicationQosEnableProperty in createDefaultProperties is enough

[xixingya]

@AlbumenJ PTAL

[xixingya]

but the other spring default props also not valid in dubbo.properties such as dubbo.config.multiple, because the application.yml is load before dubbo.properties @AlbumenJ

[AlbumenJ]

Please also fix test cases

[codecov-commenter]

Codecov Report

Merging #12861 (5c39436) into 3.2 (ceae48e) will decrease coverage by 0.38%.
Report is 6 commits behind head on 3.2.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12861      +/-   ##
============================================
- Coverage     69.82%   69.45%   -0.38%     
+ Complexity      341        2     -339     
============================================
  Files          3523     1648    -1875     
  Lines        167515    68379   -99136     
  Branches      28043     9990   -18053     
============================================
- Hits         116971    47491   -69480     
+ Misses        40459    16299   -24160     
+ Partials      10085     4589    -5496     

see 1933 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[AlbumenJ]

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[AlbumenJ]

LGTM @chickenlj PTAL

[chickenlj]

LGTM.