Skip to content

Conversation

@Fancy-hjyp
Copy link
Contributor

@Fancy-hjyp Fancy-hjyp commented Jul 21, 2023

What is the purpose of the change

[OSPP 2023] JSON Compatibility Check
#12699

Brief changelog

  • chage file of dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/deploy/DefaultModuleDeployer.java

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ
Copy link
Member

Please fix build issues

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 67 Code Smells

88.5% 88.5% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.08%. Comparing base (80d496c) to head (32d4532).
Report is 1388 commits behind head on 3.3.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #12776      +/-   ##
============================================
- Coverage     68.11%   68.08%   -0.03%     
  Complexity        6        6              
============================================
  Files          1703     1702       -1     
  Lines         70133    70183      +50     
  Branches      10175    10200      +25     
============================================
+ Hits          47768    47782      +14     
- Misses        17719    17734      +15     
- Partials       4646     4667      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CrazyHZM CrazyHZM merged commit b18eeb7 into apache:3.3 Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants