-
Notifications
You must be signed in to change notification settings - Fork 26.6k
[OSPP 2023] JSON Compatibility Check #12776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Please fix build issues |
CrazyHZM
requested changes
Aug 3, 2023
dubbo-common/src/test/java/org/apache/dubbo/common/utils/json/Service.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #12776 +/- ##
============================================
- Coverage 68.11% 68.08% -0.03%
Complexity 6 6
============================================
Files 1703 1702 -1
Lines 70133 70183 +50
Branches 10175 10200 +25
============================================
+ Hits 47768 47782 +14
- Misses 17719 17734 +15
- Partials 4646 4667 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CrazyHZM
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.








What is the purpose of the change
[OSPP 2023] JSON Compatibility Check
#12699
Brief changelog
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/deploy/DefaultModuleDeployer.javaVerifying this change
Checklist