Skip to content

Conversation

@AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Jul 2, 2023

What is the purpose of the change

Fix service context cleaned in ConsumerContextFilter will affect other cluster filters get remote attributes.

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

AlbumenJ added a commit to AlbumenJ/dubbo-samples that referenced this pull request Jul 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2023

Codecov Report

Merging #12643 (897fe6a) into 3.2 (94e7244) will decrease coverage by 0.24%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12643      +/-   ##
============================================
- Coverage     69.64%   69.40%   -0.24%     
+ Complexity      340        2     -338     
============================================
  Files          3481     1629    -1852     
  Lines        165102    67379   -97723     
  Branches      27734     9882   -17852     
============================================
- Hits         114985    46765   -68220     
+ Misses        40116    16099   -24017     
+ Partials      10001     4515    -5486     

see 1892 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit 7264850 into apache:3.2 Jul 3, 2023
AlbumenJ added a commit to apache/dubbo-samples that referenced this pull request Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants