Support multi registries metrics key #12582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.2 #12582 +/- ##
============================================
+ Coverage 69.40% 69.42% +0.02%
Complexity 2 2
============================================
Files 1644 1646 +2
Lines 68196 68296 +100
Branches 9973 9976 +3
============================================
+ Hits 47329 47413 +84
- Misses 16288 16300 +12
- Partials 4579 4583 +4 see 60 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AlbumenJ
requested changes
Jun 28, 2023
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
Outdated
Show resolved
Hide resolved
Member
|
|
AlbumenJ
requested changes
Jul 17, 2023
...fig/dubbo-config-api/src/main/java/org/apache/dubbo/config/deploy/DefaultModuleDeployer.java
Outdated
Show resolved
Hide resolved
AlbumenJ
requested changes
Jul 17, 2023
Member
AlbumenJ
left a comment
AlbumenJ
left a comment
There was a problem hiding this comment.
RegistryDirectory should also be categoried with REGISTRY_CLUSTER too
...pi/src/main/java/org/apache/dubbo/registry/client/metadata/ServiceInstanceMetadataUtils.java
Outdated
Show resolved
Hide resolved
...fig/dubbo-config-api/src/main/java/org/apache/dubbo/config/deploy/DefaultModuleDeployer.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Issue Number: close #12531
app-level
service-level
