Skip to content

Conversation

@finefuture
Copy link
Contributor

What is the purpose of the change

The uniqueness of ServiceInstancesChangedListener should not be determined by listeners, because listeners is variable object, the same ServiceInstancesChangedListener object will be repeatedly added to the listener list, just use provider appname.

Brief changelog

Verifying this change

before:
image
after:
image

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.91%. Comparing base (e026b5b) to head (607430c).
⚠️ Report is 811 commits behind head on 3.2.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.2   #12547      +/-   ##
============================================
- Coverage     69.76%   66.91%   -2.85%     
+ Complexity      318        2     -316     
============================================
  Files          3481     1763    -1718     
  Lines        165219    70861   -94358     
  Branches      27754    10158   -17596     
============================================
- Hits         115265    47419   -67846     
+ Misses        39950    18870   -21080     
+ Partials      10004     4572    -5432     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@finefuture finefuture requested a review from AlbumenJ June 26, 2023 06:08
@AlbumenJ
Copy link
Member

AlbumenJ commented Jul 3, 2023

@chickenlj PTAL

@AlbumenJ
Copy link
Member

AlbumenJ commented Jul 3, 2023

@CrazyHZM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@AlbumenJ AlbumenJ merged commit 78ca5e5 into apache:3.2 Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants