Skip to content

Conversation

@conghuhu
Copy link
Contributor

@conghuhu conghuhu commented Jun 6, 2023

What is the purpose of the change

I found Dubbo can not convert String to Duration.class in config from #12453

So I resloved it.

image

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@conghuhu
Copy link
Contributor Author

conghuhu commented Jun 6, 2023

@AlbumenJ @chickenlj @songxiaosheng PTAL

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

69.4% 69.4% Coverage
0.0% 0.0% Duplication

@AlbumenJ AlbumenJ merged commit 9af6fbf into apache:3.2 Jun 7, 2023
@conghuhu conghuhu deleted the duration branch June 8, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants