Skip to content

Conversation

@AlbumenJ
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

Codecov Report

Merging #12388 (16591ed) into 3.2 (07f0ff8) will decrease coverage by 2.65%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12388      +/-   ##
============================================
- Coverage     69.68%   67.04%   -2.65%     
  Complexity        2        2              
============================================
  Files          1583     1741     +158     
  Lines         65183    69515    +4332     
  Branches       9508     9993     +485     
============================================
+ Hits          45423    46603    +1180     
- Misses        15392    18398    +3006     
- Partials       4368     4514     +146     

see 392 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.8% 81.8% Coverage
0.0% 0.0% Duplication

@AlbumenJ AlbumenJ merged commit 16daf95 into apache:3.2 May 24, 2023
AlbumenJ added a commit that referenced this pull request May 24, 2023
* Skip scan object class

* Skip scan object class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants