Skip to content

Conversation

@trytocatch
Copy link
Contributor

What is the purpose of the change

to fix #12290

Brief changelog

  1. clean the RpcContext in ThreadLocal after QoS invoke in the InvokeTelnet
  2. synchronously get the result while async started, so the invoke command could get the correct result instead of null

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

…get the result while async started, so the invoke command could get the correct result instead of null
add Thread.interrupt to the catch block
add Thread.interrupt to the catch block
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

31.6% 31.6% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2023

Codecov Report

Merging #12291 (552dcfb) into 3.2 (89f8398) will decrease coverage by 0.51%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12291      +/-   ##
============================================
- Coverage     69.87%   69.36%   -0.51%     
+ Complexity      316        2     -314     
============================================
  Files          1825     1605     -220     
  Lines         95043    66202   -28841     
  Branches      17297     9716    -7581     
============================================
- Hits          66408    45922   -20486     
+ Misses        23228    15843    -7385     
+ Partials       5407     4437     -970     

see 3430 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ merged commit c916b82 into apache:3.2 May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

the telnet invoke did not clean the ThreadLocal, causing the request response pairing errors

3 participants