-
Notifications
You must be signed in to change notification settings - Fork 26.6k
Display indicator data in KEY, VALUE format #12273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
songxiaosheng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix ci problem
2023-05-09T13:25:40.8188103Z [INFO]
2023-05-09T13:25:40.8188695Z [ERROR] Failures:
2023-05-09T13:25:40.8189133Z [ERROR] CommandHelperTest.testGetAllCommandClass:128
2023-05-09T13:25:40.8195644Z Expected: iterable with items [<class org.apache.dubbo.qos.command.GreetingCommand>, <class org.apache.dubbo.qos.command.impl.Help>, <class org.apache.dubbo.qos.command.impl.Live>, <class org.apache.dubbo.qos.command.impl.Ls>, <class org.apache.dubbo.qos.command.impl.Offline>, <class org.apache.dubbo.qos.command.impl.OfflineApp>, <class org.apache.dubbo.qos.command.impl.OfflineInterface>, <class org.apache.dubbo.qos.command.impl.Online>, <class org.apache.dubbo.qos.command.impl.OnlineApp>, <class org.apache.dubbo.qos.command.impl.OnlineInterface>, <class org.apache.dubbo.qos.command.impl.PublishMetadata>, <class org.apache.dubbo.qos.command.impl.Quit>, <class org.apache.dubbo.qos.command.impl.Ready>, <class org.apache.dubbo.qos.command.impl.Startup>, <class org.apache.dubbo.qos.command.impl.Version>, <class org.apache.dubbo.qos.command.impl.ChangeTelnet>, <class org.apache.dubbo.qos.command.impl.CountTelnet>, <class org.apache.dubbo.qos.command.impl.InvokeTelnet>, <class org.apache.dubbo.qos.command.impl.SelectTelnet>, <class org.apache.dubbo.qos.command.impl.PortTelnet>, <class org.apache.dubbo.qos.command.impl.PwdTelnet>, <class org.apache.dubbo.qos.command.impl.ShutdownTelnet>, <class org.apache.dubbo.qos.command.impl.EnableDetailProfiler>, <class org.apache.dubbo.qos.command.impl.DisableDetailProfiler>, <class org.apache.dubbo.qos.command.impl.EnableSimpleProfiler>, <class org.apache.dubbo.qos.command.impl.DisableSimpleProfiler>, <class org.apache.dubbo.qos.command.impl.SetProfilerWarnPercent>, <class org.apache.dubbo.qos.command.impl.GetRouterSnapshot>, <class org.apache.dubbo.qos.command.impl.GetEnabledRouterSnapshot>, <class org.apache.dubbo.qos.command.impl.EnableRouterSnapshot>, <class org.apache.dubbo.qos.command.impl.DisableRouterSnapshot>, <class org.apache.dubbo.qos.command.impl.GetRecentRouterSnapshot>, <class org.apache.dubbo.qos.command.impl.LoggerInfo>, <class org.apache.dubbo.qos.command.impl.SwitchLogger>, <class org.apache.dubbo.qos.command.impl.SwitchLogLevel>, <class org.apache.dubbo.qos.command.impl.SerializeCheckStatus>, <class org.apache.dubbo.qos.command.impl.SerializeWarnedClasses>, <class org.apache.dubbo.qos.command.impl.GetConfig>, <class org.apache.dubbo.qos.command.impl.GetAddress>, <class org.apache.dubbo.qos.command.impl.GracefulShutdown>] in any order
2023-05-09T13:25:40.8201547Z but: not matched: <class org.apache.dubbo.metrics.report.DefaultMetricsReporterCmd>
…dependency in the dependencies.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.2 #12273 +/- ##
============================================
- Coverage 69.65% 69.29% -0.36%
+ Complexity 315 2 -313
============================================
Files 3439 1613 -1826
Lines 162057 66506 -95551
Branches 27195 9755 -17440
============================================
- Hits 112878 46086 -66792
+ Misses 39258 15967 -23291
+ Partials 9921 4453 -5468 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
...ubbo-config-api/src/main/java/org/apache/dubbo/config/deploy/DefaultApplicationDeployer.java
Show resolved
Hide resolved
...bo-metrics-default/src/main/java/org/apache/dubbo/metrics/report/DefaultMetricsReporter.java
Show resolved
Hide resolved
2.method replace
songxiaosheng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix exception when use metrics_default command
...gin/dubbo-qos/src/main/java/org/apache/dubbo/qos/command/impl/DefaultMetricsReporterCmd.java
Outdated
Show resolved
Hide resolved
...gin/dubbo-qos/src/main/java/org/apache/dubbo/qos/command/impl/DefaultMetricsReporterCmd.java
Show resolved
Hide resolved
|
简化下输出内容,方便后续应用反向解码即可 |
|
Kudos, SonarCloud Quality Gate passed! |
songxiaosheng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM








What is the purpose of the change
for #11954
当用户未引入prometheus的时候,使用默认的监控,并且可以通过qos查看全部监控指标和某一类监控指标
Brief changelog
Verifying this change
Checklist