Skip to content

Conversation

@hujun-w-2
Copy link
Contributor

@hujun-w-2 hujun-w-2 commented May 9, 2023

What is the purpose of the change

for #11954
当用户未引入prometheus的时候,使用默认的监控,并且可以通过qos查看全部监控指标和某一类监控指标

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix ci problem

2023-05-09T13:25:40.8188103Z [INFO] 
2023-05-09T13:25:40.8188695Z [ERROR] Failures: 
2023-05-09T13:25:40.8189133Z [ERROR]   CommandHelperTest.testGetAllCommandClass:128 
2023-05-09T13:25:40.8195644Z Expected: iterable with items [<class org.apache.dubbo.qos.command.GreetingCommand>, <class org.apache.dubbo.qos.command.impl.Help>, <class org.apache.dubbo.qos.command.impl.Live>, <class org.apache.dubbo.qos.command.impl.Ls>, <class org.apache.dubbo.qos.command.impl.Offline>, <class org.apache.dubbo.qos.command.impl.OfflineApp>, <class org.apache.dubbo.qos.command.impl.OfflineInterface>, <class org.apache.dubbo.qos.command.impl.Online>, <class org.apache.dubbo.qos.command.impl.OnlineApp>, <class org.apache.dubbo.qos.command.impl.OnlineInterface>, <class org.apache.dubbo.qos.command.impl.PublishMetadata>, <class org.apache.dubbo.qos.command.impl.Quit>, <class org.apache.dubbo.qos.command.impl.Ready>, <class org.apache.dubbo.qos.command.impl.Startup>, <class org.apache.dubbo.qos.command.impl.Version>, <class org.apache.dubbo.qos.command.impl.ChangeTelnet>, <class org.apache.dubbo.qos.command.impl.CountTelnet>, <class org.apache.dubbo.qos.command.impl.InvokeTelnet>, <class org.apache.dubbo.qos.command.impl.SelectTelnet>, <class org.apache.dubbo.qos.command.impl.PortTelnet>, <class org.apache.dubbo.qos.command.impl.PwdTelnet>, <class org.apache.dubbo.qos.command.impl.ShutdownTelnet>, <class org.apache.dubbo.qos.command.impl.EnableDetailProfiler>, <class org.apache.dubbo.qos.command.impl.DisableDetailProfiler>, <class org.apache.dubbo.qos.command.impl.EnableSimpleProfiler>, <class org.apache.dubbo.qos.command.impl.DisableSimpleProfiler>, <class org.apache.dubbo.qos.command.impl.SetProfilerWarnPercent>, <class org.apache.dubbo.qos.command.impl.GetRouterSnapshot>, <class org.apache.dubbo.qos.command.impl.GetEnabledRouterSnapshot>, <class org.apache.dubbo.qos.command.impl.EnableRouterSnapshot>, <class org.apache.dubbo.qos.command.impl.DisableRouterSnapshot>, <class org.apache.dubbo.qos.command.impl.GetRecentRouterSnapshot>, <class org.apache.dubbo.qos.command.impl.LoggerInfo>, <class org.apache.dubbo.qos.command.impl.SwitchLogger>, <class org.apache.dubbo.qos.command.impl.SwitchLogLevel>, <class org.apache.dubbo.qos.command.impl.SerializeCheckStatus>, <class org.apache.dubbo.qos.command.impl.SerializeWarnedClasses>, <class org.apache.dubbo.qos.command.impl.GetConfig>, <class org.apache.dubbo.qos.command.impl.GetAddress>, <class org.apache.dubbo.qos.command.impl.GracefulShutdown>] in any order
2023-05-09T13:25:40.8201547Z      but: not matched: <class org.apache.dubbo.metrics.report.DefaultMetricsReporterCmd>

@hujun-w-2 hujun-w-2 requested a review from songxiaosheng May 20, 2023 14:05
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.29%. Comparing base (50798b9) to head (f5f88e2).
⚠️ Report is 944 commits behind head on 3.2.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.2   #12273      +/-   ##
============================================
- Coverage     69.65%   69.29%   -0.36%     
+ Complexity      315        2     -313     
============================================
  Files          3439     1613    -1826     
  Lines        162057    66506   -95551     
  Branches      27195     9755   -17440     
============================================
- Hits         112878    46086   -66792     
+ Misses        39258    15967   -23291     
+ Partials       9921     4453    -5468     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

2.method replace
Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix exception when use metrics_default command

@songxiaosheng
Copy link
Member

简化下输出内容,方便后续应用反向解码即可

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

11.3% 11.3% Coverage
0.0% 0.0% Duplication

Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songxiaosheng songxiaosheng merged commit 1697a33 into apache:3.2 May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants