Skip to content

Fix allow non-serializable check#12267

Merged
AlbumenJ merged 5 commits intoapache:3.2from
AlbumenJ:0509_serialize
May 16, 2023
Merged

Fix allow non-serializable check#12267
AlbumenJ merged 5 commits intoapache:3.2from
AlbumenJ:0509_serialize

Conversation

@AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented May 9, 2023

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@xieshouyu
Copy link
Contributor

It is recommended to set CheckSerializable as false by default, as upgrading for older users is smoother

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.00%. Comparing base (14b68d7) to head (438db93).
⚠️ Report is 982 commits behind head on 3.2.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.2   #12267      +/-   ##
============================================
- Coverage     69.60%   67.00%   -2.60%     
+ Complexity      341        2     -339     
============================================
  Files          3432     1739    -1693     
  Lines        161384    69421   -91963     
  Branches      27050     9972   -17078     
============================================
- Hits         112334    46519   -65815     
+ Misses        39161    18404   -20757     
+ Partials       9889     4498    -5391     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlbumenJ
Copy link
Member Author

It is recommended to set CheckSerializable as false by default, as upgrading for older users is smoother

For All of the Dubbo versions (2.0.x ~ 3.2.x) are reject non-Serializable class by default for security purpose.

@AlbumenJ
Copy link
Member Author

It is recommended to set CheckSerializable as false by default, as upgrading for older users is smoother

done

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

@AlbumenJ AlbumenJ merged commit 9065171 into apache:3.2 May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments