Skip to content

Conversation

@conghuhu
Copy link
Contributor

@conghuhu conghuhu commented Apr 18, 2023

…with v3.2.0

What is the purpose of the change

  • recover dubbo-spring-boot-observability-starter to compatible with v3.2.0
  • change tracing applicationName from env
    image

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

Codecov Report

Merging #12124 (bb26ec1) into 3.2 (0b62b40) will decrease coverage by 0.24%.
The diff coverage is n/a.

❗ Current head bb26ec1 differs from pull request most recent head 556ed3f. Consider uploading reports for the commit 556ed3f to get more accurate results

@@             Coverage Diff              @@
##                3.2   #12124      +/-   ##
============================================
- Coverage     69.76%   69.53%   -0.24%     
+ Complexity      129        2     -127     
============================================
  Files          3397     1589    -1808     
  Lines        159184    65330   -93854     
  Branches      26291     9513   -16778     
============================================
- Hits         111061    45428   -65633     
+ Misses        38447    15537   -22910     
+ Partials       9676     4365    -5311     

see 1858 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@conghuhu
Copy link
Contributor Author

@AlbumenJ @songxiaosheng PTAL

@conghuhu conghuhu force-pushed the cgq branch 2 times, most recently from 2096d17 to e671dce Compare April 19, 2023 08:43
Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can future unused types be marked as outdated

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts

Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 17 Code Smells

1.2% 1.2% Coverage
0.0% 0.0% Duplication

@conghuhu
Copy link
Contributor Author

@AlbumenJ PTAL

@AlbumenJ AlbumenJ merged commit 48bd823 into apache:3.2 Apr 24, 2023
@conghuhu conghuhu deleted the cgq branch April 25, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants