Skip to content

Conversation

@songxiaosheng
Copy link
Member

What is the purpose of the change

🐛 fix the disorder of aggregation indicators

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

88.7% 88.7% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #11753 (75088dc) into 3.2 (d3d8c54) will decrease coverage by 0.67%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #11753      +/-   ##
============================================
- Coverage     69.49%   68.83%   -0.67%     
+ Complexity      339        2     -337     
============================================
  Files          1711     1529     -182     
  Lines         89136    63467   -25669     
  Branches      16198     9300    -6898     
============================================
- Hits          61946    43686   -18260     
+ Misses        22086    15518    -6568     
+ Partials       5104     4263     -841     
Impacted Files Coverage Δ
...a/org/apache/dubbo/metrics/event/MetricsEvent.java
...ava/org/apache/dubbo/metrics/model/MetricsKey.java
...o/metrics/collector/AggregateMetricsCollector.java
...metrics/collector/sample/MethodMetricsSampler.java
...dubbo/metrics/filter/MethodMetricsInterceptor.java
...che/dubbo/metrics/filter/MetricsClusterFilter.java
.../observation/DubboClientObservationConvention.java
...trics/registry/event/MetricsSubscribeListener.java
.../dubbo/remoting/http/jetty/JettyLoggerAdapter.java
.../rpc/protocol/tri/call/StubAbstractServerCall.java
... and 3230 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@songxiaosheng
Copy link
Member Author

@AlbumenJ PTAL

@AlbumenJ AlbumenJ merged commit 8d1152d into apache:3.2 Mar 10, 2023
lcb11 pushed a commit to lcb11/dubbo that referenced this pull request Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants