-
Notifications
You must be signed in to change notification settings - Fork 26.6k
Remove grpc-status-details when no pb exists #11249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.1 #11249 +/- ##
============================================
- Coverage 69.62% 64.46% -5.17%
+ Complexity 114 14 -100
============================================
Files 1503 1422 -81
Lines 80063 59360 -20703
Branches 14135 8726 -5409
============================================
- Hits 55745 38264 -17481
+ Misses 19538 17029 -2509
+ Partials 4780 4067 -713
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Class.forName 用全限定名更合适吧,要不然 JVM 抛出的会是 NoClassDefFoundError。 (复现) public class X {
public static void main(String[] args) {
try {
Class.forName(X2.class.getName());
} catch (ClassNotFoundException cnfe) {
System.out.println("ClassNotFoundException");
} catch (NoClassDefFoundError ncdfe) {
System.out.println("NoClassDefFoundError");
}
}
}public class X2 {
// 内容随便,有个类就行。
public void m1() {
System.out.println(Object.class.getName());
}
} |
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleProtocol.java
Outdated
Show resolved
Hide resolved
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleProtocol.java
Outdated
Show resolved
Hide resolved
.../dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/stream/AbstractStream.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
guohao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM








What is the purpose of the change
Brief changelog
Verifying this change
Checklist