Skip to content

Fix deadlocks in lazy-init situations. #11194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlbumenJ merged 2 commits into from
Dec 25, 2022
Merged

Fix deadlocks in lazy-init situations. #11194

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7aae95c
Fix deadlocks in lazy-init situations.
wuwen5 Dec 22, 2022
83044e7
Fix deadlocks in lazy-init situations(Compatible with versions earlie…
wuwen5 Dec 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...onfig/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/ReferenceBean.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,11 @@ private Object getCallProxy() throws Exception {
throw new IllegalStateException("ReferenceBean is not ready yet, please make sure to call reference interface method after dubbo is started.");
}
//get reference proxy
return referenceConfig.get();
//Subclasses should synchronize on the given Object if they perform any sort of extended singleton creation phase.
// In particular, subclasses should not have their own mutexes involved in singleton creation, to avoid the potential for deadlocks in lazy-init situations.
synchronized (getBeanFactory().getSingletonMutex()) {
return referenceConfig.get();
}
}

private class DubboReferenceLazyInitTargetSource extends AbstractLazyCreationTargetSource {
Expand Down