Skip to content

Conversation

@win120a
Copy link
Contributor

@win120a win120a commented Dec 21, 2022

What is the purpose of the change

Add missing error code.

Brief changelog

  1. Add error code of 'port is overridden' hint.
  2. Since 4-19 is same as 0-2, this PR merged original code 4-19 to code 0-2.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

20.0% 20.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #11181 (18742f0) into 3.1 (0b2a8f0) will decrease coverage by 4.63%.
The diff coverage is 30.00%.

@@             Coverage Diff              @@
##                3.1   #11181      +/-   ##
============================================
- Coverage     69.29%   64.66%   -4.64%     
+ Complexity      127       14     -113     
============================================
  Files          1502     1421      -81     
  Lines         78949    59304   -19645     
  Branches      13842     8720    -5122     
============================================
- Hits          54711    38346   -16365     
+ Misses        19484    16920    -2564     
+ Partials       4754     4038     -716     
Impacted Files Coverage Δ
...t/migration/DefaultMigrationAddressComparator.java 79.54% <0.00%> (-2.28%) ⬇️
...gistry/client/migration/MigrationRuleListener.java 66.94% <0.00%> (-6.00%) ⬇️
...bo/registry/support/CacheableFailbackRegistry.java 78.82% <0.00%> (-7.69%) ⬇️
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 82.46% <0.00%> (-4.92%) ⬇️
...he/dubbo/config/context/AbstractConfigManager.java 78.57% <50.00%> (-2.52%) ⬇️
.../org/apache/dubbo/common/config/Configuration.java 78.43% <100.00%> (-1.06%) ⬇️
...ient/metadata/ProtocolPortsMetadataCustomizer.java 88.88% <100.00%> (-1.12%) ⬇️
...luster/router/script/ScriptStateRouterFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...he/dubbo/test/common/impl/GreetingServiceImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...zookeeper/curator/CuratorZookeeperTransporter.java 0.00% <0.00%> (-100.00%) ⬇️
... and 497 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit 1bfd354 into apache:3.1 Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants