Skip to content

Conversation

@AlbumenJ
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ AlbumenJ requested a review from CrazyHZM December 20, 2022 15:28
# Conflicts:
#	dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/bootstrap/MultiInstanceTest.java
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

59.5% 59.5% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #11142 (31cb63c) into 3.1 (e7146d7) will decrease coverage by 4.89%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##                3.1   #11142      +/-   ##
============================================
- Coverage     69.46%   64.57%   -4.90%     
+ Complexity      127       14     -113     
============================================
  Files          1496     1421      -75     
  Lines         78820    59312   -19508     
  Branches      13842     8721    -5121     
============================================
- Hits          54752    38300   -16452     
+ Misses        19344    16968    -2376     
+ Partials       4724     4044     -680     
Impacted Files Coverage Δ
...ava/org/apache/dubbo/config/ServiceConfigBase.java 75.00% <50.00%> (-7.36%) ⬇️
.../java/org/apache/dubbo/config/ReferenceConfig.java 73.46% <50.00%> (-12.82%) ⬇️
...n/java/org/apache/dubbo/config/AbstractConfig.java 81.53% <87.50%> (-4.63%) ⬇️
...g/apache/dubbo/config/AbstractInterfaceConfig.java 79.61% <100.00%> (-4.32%) ⬇️
.../org/apache/dubbo/config/AbstractMethodConfig.java 88.46% <100.00%> (+0.22%) ⬆️
...ain/java/org/apache/dubbo/config/ModuleConfig.java 65.57% <100.00%> (+1.16%) ⬆️
...a/org/apache/dubbo/config/ReferenceConfigBase.java 59.44% <100.00%> (-6.46%) ⬇️
...luster/router/script/ScriptStateRouterFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...he/dubbo/test/common/impl/GreetingServiceImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...zookeeper/curator/CuratorZookeeperTransporter.java 0.00% <0.00%> (-100.00%) ⬇️
... and 492 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrazyHZM CrazyHZM merged commit 4a2566d into apache:3.1 Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants