Skip to content

Conversation

@AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Dec 4, 2022

What is the purpose of the change

  • Add default thread name for protocol
  • Defaultly do not create isolated executor

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ AlbumenJ requested a review from BurningCN December 4, 2022 08:58
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

11.1% 11.1% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #11069 (a57024a) into 3.2 (6118dd8) will increase coverage by 0.03%.
The diff coverage is 54.28%.

@@             Coverage Diff              @@
##                3.2   #11069      +/-   ##
============================================
+ Coverage     64.80%   64.83%   +0.03%     
  Complexity       14       14              
============================================
  Files          1445     1448       +3     
  Lines         60313    60324      +11     
  Branches       8839     8842       +3     
============================================
+ Hits          39083    39110      +27     
+ Misses        17133    17087      -46     
- Partials       4097     4127      +30     
Impacted Files Coverage Δ
...c/main/java/org/apache/dubbo/config/Constants.java 100.00% <ø> (ø)
...bo/remoting/zookeeper/AbstractZookeeperClient.java 85.05% <ø> (+3.44%) ⬆️
...ng/transport/netty/NettyPortUnificationServer.java 0.00% <0.00%> (ø)
...ting/zookeeper/curator/CuratorZookeeperClient.java 13.53% <0.00%> (ø)
...he/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java 92.53% <ø> (+3.96%) ⬆️
...e/autoconfigure/DubboMetricsAutoConfiguration.java 0.00% <0.00%> (ø)
...pring/boot/actuate/mertics/DubboMetricsBinder.java 0.00% <0.00%> (ø)
...in/java/org/apache/dubbo/metrics/DubboMetrics.java 20.00% <20.00%> (ø)
...in/java/org/apache/dubbo/rpc/support/RpcUtils.java 61.06% <33.33%> (+1.67%) ⬆️
.../apache/dubbo/metrics/AbstractMetricsReporter.java 66.66% <40.00%> (-1.08%) ⬇️
... and 81 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@BurningCN BurningCN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit 0d2cab4 into apache:3.2 Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants