Skip to content

Conversation

@gitchenjh
Copy link
Contributor

What is the purpose of the change

fix #10880

Brief changelog

Set true as default value of ApplicationConfig.enableFileCache

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.88%. Comparing base (4e37fa0) to head (05180de).
Report is 1712 commits behind head on 3.2.

Additional details and impacted files
@@            Coverage Diff            @@
##                3.2   #11008   +/-   ##
=========================================
  Coverage     64.88%   64.88%           
  Complexity       14       14           
=========================================
  Files          1443     1443           
  Lines         59908    59909    +1     
  Branches       8776     8777    +1     
=========================================
+ Hits          38871    38872    +1     
+ Misses        16940    16938    -2     
- Partials       4097     4099    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will fix #10880

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ApplicationConfig的enableFileCache属性默认null,导致无本地缓存

3 participants