Skip to content

Conversation

@conghuhu
Copy link
Contributor

What is the purpose of the change

WireProtocol still relies on netty at present. I decouple channel pipeline.

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 18 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #10976 (13e96a5) into 3.2 (09ca5d6) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##                3.2   #10976   +/-   ##
=========================================
  Coverage     20.60%   20.60%           
  Complexity       14       14           
=========================================
  Files          1441     1441           
  Lines         59836    59841    +5     
  Branches       8771     8771           
=========================================
+ Hits          12330    12333    +3     
- Misses        45429    45430    +1     
- Partials       2077     2078    +1     
Impacted Files Coverage Δ
.../java/org/apache/dubbo/qos/pu/QosWireProtocol.java 44.44% <ø> (+4.44%) ⬆️
...pache/dubbo/remoting/api/AbstractWireProtocol.java 66.66% <ø> (ø)
...moting/transport/netty4/NettyConnectionClient.java 0.00% <0.00%> (ø)
...he/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java 3.03% <0.00%> (-0.20%) ⬇️
.../config/spring/context/DubboSpringInitializer.java 68.67% <0.00%> (+2.40%) ⬆️
.../config/spring/context/DubboSpringInitContext.java 72.00% <0.00%> (+4.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ requested a review from CrazyHZM November 22, 2022 02:54
@CrazyHZM CrazyHZM merged commit 734c9c3 into apache:3.2 Nov 22, 2022
@conghuhu conghuhu deleted the netty branch January 29, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants