Skip to content

Conversation

@haoyann
Copy link
Contributor

@haoyann haoyann commented Nov 18, 2022

What is the purpose of the change

相关 issue #10581, 解析路由规则参考了 https://github.com/grpc/grpc-java 部分代码.

  • XdsRoute 监听 RDS 获取路由规则,完成 uri、head 匹配功能,监听 EDS 获取 endpoint 数据,完成对实例 subsets 的适配;
  • 支持集群权重配置

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@chickenlj
Copy link
Contributor

I will be looking into this feature.

@chickenlj chickenlj self-requested a review November 21, 2022 02:11
Comment on lines 39 to 41
ScopeBeanFactory beanFactory = moduleModel.getBeanFactory();
beanFactory.registerBean(RdsRouteRuleManager.class);
beanFactory.registerBean(EdsEndpointManager.class);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to application model level

@chickenlj chickenlj added the status/don’t-merge No plan to merge label Nov 23, 2022
@chickenlj
Copy link
Contributor

still working on it

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ removed the status/don’t-merge No plan to merge label Dec 7, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 89 Code Smells

82.7% 82.7% Coverage
0.0% 0.0% Duplication

@AlbumenJ AlbumenJ merged commit f95e659 into apache:3.2 Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants