Skip to content

DefaultModuleDeployer start fail, but export MetadataService #12315

@AYue-94

Description

@AYue-94

Environment

  • Dubbo version: 3.2.0
  • Operating System version: macos10.15.7
  • Java version: 1.8

Steps to reproduce this issue

使用各种方式导致Module启动失败。

Expected Behavior

Module启动失败,不暴露MetadataService。

即不执行DefaultApplicationDeployer#prepareApplicationInstance。

Actual Behavior

由于org.apache.dubbo.config.deploy.DefaultModuleDeployer#onModuleFailed传入错误的状态STARTED,导致执行DefaultApplicationDeployer#prepareApplicationInstance。

private void onModuleFailed(String msg, Throwable ex) {
    try {
        setFailed(ex);
        logger.error(CONFIG_FAILED_START_MODEL, "", "", "Model start failed: " + msg, ex);
        applicationDeployer.notifyModuleChanged(moduleModel, DeployState.STARTED);
    } finally {
        completeStartFuture(false);
    }
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    type/bugBugs to being fixed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions