Skip to content

move internal into dubbo-go-samples repo#2794

Merged
AlexStocks merged 2 commits intoapache:developfrom
marsevilspirit:mv-tirple-internal
Mar 22, 2025
Merged

move internal into dubbo-go-samples repo#2794
AlexStocks merged 2 commits intoapache:developfrom
marsevilspirit:mv-tirple-internal

Conversation

@marsevilspirit
Copy link
Member

#2498

move internal into dubbo-go-samples repo.
apache/dubbo-go-samples#809

@No-SilverBullet
Copy link
Member

Please check the CI error, this commit is a BREAKING change, we need to make sure everything is ok.

@marsevilspirit
Copy link
Member Author

My mistake, i will fix it soon.

@marsevilspirit marsevilspirit changed the title move internal into dubbo-go-samples repo [WIP]move internal into dubbo-go-samples repo Mar 10, 2025
@marsevilspirit
Copy link
Member Author

triple_test.go depends on the internal directory, and the next step is to move this test to the integration tests in the samples.

@sonarqubecloud
Copy link

@marsevilspirit marsevilspirit changed the title [WIP]move internal into dubbo-go-samples repo move internal into dubbo-go-samples repo Mar 11, 2025
Copy link
Contributor

@FoghostCn FoghostCn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks merged commit bc98c2d into apache:develop Mar 22, 2025
6 checks passed
@marsevilspirit marsevilspirit deleted the mv-tirple-internal branch April 4, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants