Skip to content

Functional implementation of the llm example#802

Merged
AlexStocks merged 15 commits intoapache:mainfrom
Alanxtl:main
Mar 8, 2025
Merged

Functional implementation of the llm example#802
AlexStocks merged 15 commits intoapache:mainfrom
Alanxtl:main

Conversation

@Alanxtl
Copy link
Contributor

@Alanxtl Alanxtl commented Mar 6, 2025

I'm lixuetao. All of the features mentioned in #800 have implemented, which includes:

  1. cli client: multi-turn conversations, command interact, context management.
  2. web client: multi-turn conversations, binary file transform through rpc and support for LLM interactions

@AlexStocks
Copy link
Contributor

Is this PR in progress or completed?

@Alanxtl
Copy link
Contributor Author

Alanxtl commented Mar 7, 2025

Is this PR in progress or completed?

It is completed.

@Alanxtl
Copy link
Contributor Author

Alanxtl commented Mar 8, 2025

@AlexStocks
Thanks for the careful comment, I've fixed all of the problems you mentioned, specifically:

  1. Use imports-formatter to format all of the files.
  2. Rewrite all of the Chinese comments.
  3. Wrapping some of the functionality from chat.go to context.go, to reduce lock scope and achieve decoupling effect.

btw, there are three files
llm/go-client/frontend/templates/index.html
llm/go-client/frontend/static/script.js
llm/go-client/frontend/static/style.css
which I cloned from another repo and changed a lot of lines. However, this repo doesn't specify the open source license. I didn't add the ASF license to these files, and I added comments at the beginning of each file giving their source. I'm not sure if this is the right way or not.

@apache apache deleted a comment from Alanxtl Mar 8, 2025
@AlexStocks AlexStocks merged commit c144f4a into apache:main Mar 8, 2025
0 of 2 checks passed
@Alanxtl Alanxtl mentioned this pull request Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants