feat:add llm integration example with ollama to dubbo-go#793
Merged
AlexStocks merged 4 commits intoapache:developfrom Feb 24, 2025
Merged
feat:add llm integration example with ollama to dubbo-go#793AlexStocks merged 4 commits intoapache:developfrom
AlexStocks merged 4 commits intoapache:developfrom
Conversation
AlexStocks
reviewed
Feb 24, 2025
llm/go-client/cmd/client.go
Outdated
| client.WithClientURL("tri://127.0.0.1:20000"), | ||
| ) | ||
| if err != nil { | ||
| panic(err) |
Contributor
There was a problem hiding this comment.
在 main 主 goroutine 中，不要使用 panic，这不是一个好的 编程习惯。用如下方式：
fmt.Printf()
return
AlexStocks
reviewed
Feb 24, 2025
llm/go-client/cmd/client.go
Outdated
|
|
||
| svc, err := greet.NewGreetService(cli) | ||
| if err != nil { | ||
| panic(err) |
Contributor
There was a problem hiding this comment.
在 main 主 goroutine 中，不要使用 panic，这不是一个好的 编程习惯
AlexStocks
reviewed
Feb 24, 2025
llm/go-client/cmd/client.go
Outdated
| Prompt: "Write a simple function to calculate fibonacci sequence in Go", | ||
| }) | ||
| if err != nil { | ||
| log.Fatal(err) |
Contributor
There was a problem hiding this comment.
这里面就没定义 log，改为 fmt.Printf + return 吧
AlexStocks
reviewed
Feb 24, 2025
llm/go-client/cmd/client.go
Outdated
| fmt.Print(stream.Msg().Content) | ||
| } | ||
| if err := stream.Err(); err != nil { | ||
| log.Fatal(err) |
Contributor
There was a problem hiding this comment.
这里面就没定义 log，改为 fmt.Printf + return 吧
AlexStocks
reviewed
Feb 24, 2025
…n in main goroutine, and update log handling
AlexStocks
approved these changes
Feb 24, 2025
AlexStocks
added a commit
that referenced
this pull request
Feb 24, 2025
This reverts commit f90b771.
AlexStocks
added a commit
that referenced
this pull request
Feb 24, 2025
* add llm integration example with ollama to dubbo-go (#793) * add llm integration example and update relevant files * Refactor import organization, replace panic with fmt.Printf and return in main goroutine, and update log handling * Update server.go * Update server.go --------- Co-authored-by: Xin.Zh <[email protected]> * Revert "add llm integration example with ollama to dubbo-go (#793)" This reverts commit f90b771. --------- Co-authored-by: solisamicus <[email protected]>
No-SilverBullet
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.