Skip to content

chore: remove compatibility/config-api#1018

Merged
AlexStocks merged 1 commit intoapache:mainfrom
zbchi:rm-compat/config-api
Jan 13, 2026
Merged

chore: remove compatibility/config-api#1018
AlexStocks merged 1 commit intoapache:mainfrom
zbchi:rm-compat/config-api

Conversation

@zbchi
Copy link
Contributor

@zbchi zbchi commented Jan 11, 2026

Summary

Remove compatibility/config-api/ directory as all functionality has been replaced by new API examples in the root directory.

Changes

Deleted:
compatibility/config-api/configcenter/ → replaced by config_center/
compatibility/config-api/rpc/ → replaced by rpc/triple/instance/
compatibility/config-api/config-merge/ → deprecated (use config center or env vars)
compatibility/config-api/subModule/ → incomplete code, now obtain a high-level abstraction via dubbo.NewInstance() instead of directly accessing the underlying instance.
#958

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the deprecated compatibility/config-api/ directory and all associated integration tests, as the functionality has been replaced by newer API examples in the root directory.

Changes:

  • Removed 4 integration test entries from start_integrate_test.sh for config-api examples
  • Deleted all integration test files under integrate_test/compatibility/config-api/
  • Deleted all source files and documentation under compatibility/config-api/
  • Updated both English and Chinese README files to remove references to compatibility/config-api

Reviewed changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated no comments.

Show a summary per file
File Description
start_integrate_test.sh Removed 4 commented-out config-api integration test entries
integrate_test/compatibility/config-api/rpc/triple/tests/integration/*.go Deleted RPC triple integration tests (replaced by rpc/triple/instance/)
integrate_test/compatibility/config-api/configcenter/zookeeper/tests/integration/*.go Deleted Zookeeper config center integration tests (replaced by config_center/zookeeper)
integrate_test/compatibility/config-api/configcenter/nacos/tests/integration/*.go Deleted Nacos config center integration tests (replaced by config_center/nacos)
integrate_test/compatibility/config-api/config-merge/tests/integration/*.go Deleted config merge integration tests (deprecated functionality)
compatibility/config-api/subModule/**/*.go Deleted incomplete subModule example code (replaced by dubbo.NewInstance() API)
compatibility/config-api/rpc/triple/**/*.go Deleted RPC triple client/server examples (replaced by rpc/triple/instance/)
compatibility/config-api/configcenter/**/*.go Deleted config center client/server examples (replaced by config_center/)
compatibility/config-api/config-merge/**/*.go Deleted config merge examples (deprecated functionality)
compatibility/config-api/**/*.yml Deleted all configuration files for removed examples
compatibility/config-api/**/README.md Deleted documentation for removed examples
README.md Removed reference to compatibility/config-api from project overview
README_CN.md Removed reference to compatibility/config-api from project overview (Chinese)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AlexStocks AlexStocks merged commit f4404e1 into apache:main Jan 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants