[Improvement-16994][TaskPlugin] ensure spark application cancelled #17504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abzymeatsjtu
requested review from
Gallardot,
SbloodyS and
caishunfeng
as code owners
ruanwenjun
reviewed
Sep 11, 2025
Comment on lines
+217
to
+228
|
|
||
| RunState currentState = RunState.Cancelling; | ||
|
|
||
| while (!RunState.isCancelled(currentState)) { | ||
| currentState = RunState.valueOf(pollJobRunStatus()); | ||
|
|
||
| try { | ||
| Thread.sleep(10 * 1000L); | ||
| } catch (InterruptedException e) { | ||
| break; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
We don't need to do this change, since the kill operation is async, and only handle finish, then the worker will return the task state to master. The change might block a thread.
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensure spark application cancelled when cancel application is triggered
close #16994