Skip to content

fix(9870): common expression elimination optimization, should always re-find the correct expression during re-write. #9871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 5 commits into from
Mar 31, 2024
Merged

fix(9870): common expression elimination optimization, should always re-find the correct expression during re-write. #9871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
efb8c8d
test(9870): reproducer of error with jumping traversal patterns in co…
wiedld Mar 29, 2024
a4f9acf
refactor: remove the IdArray ordered idx, since the idx ordering does…
wiedld Mar 28, 2024
87eb784
refactor: use the only reproducible key (expr_identifer) for expr_set…
wiedld Mar 28, 2024
5eb7a77
refactor: encapsulate most of the logic within ExprSet, and delineate…
wiedld Mar 30, 2024
ff7b3d6
test(9870): demonstrate that the sqllogictests are now passing
wiedld Mar 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datafusion/expr/src/logical_plan/plan.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2389,7 +2389,7 @@ impl DistinctOn {

/// Aggregates its input based on a set of grouping and aggregate
/// expressions (e.g. SUM).
#[derive(Clone, PartialEq, Eq, Hash)]
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
// mark non_exhaustive to encourage use of try_new/new()
#[non_exhaustive]
pub struct Aggregate {
Expand Down
Loading