Skip to content

feat: implement more expr_to_sql functionality #9578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 14 commits into from
Mar 14, 2024
Merged

feat: implement more expr_to_sql functionality #9578

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2ea1c93
more impls
devinjdangelo Mar 12, 2024
05f1a71
fix tests
devinjdangelo Mar 12, 2024
aedb46d
cargo update dfcli
devinjdangelo Mar 12, 2024
15f9a05
fix custom_dialect test
devinjdangelo Mar 12, 2024
48c33f5
add tests and feature flag
devinjdangelo Mar 13, 2024
b18ae76
fix comment
devinjdangelo Mar 13, 2024
b8bcd27
remove chrono use arrow-array conversions
devinjdangelo Mar 13, 2024
937e3c8
fix cargo lock again
devinjdangelo Mar 13, 2024
4b7d5f5
fix count distinct
devinjdangelo Mar 13, 2024
0cda50c
retry windows ci
devinjdangelo Mar 13, 2024
a7e4be6
retry windows ci again
devinjdangelo Mar 13, 2024
7228490
Merge branch 'main' into more_unparser_impls
devinjdangelo Mar 13, 2024
a2e8b61
add roundtrip tests
devinjdangelo Mar 13, 2024
9564e8c
cargo fmt
devinjdangelo Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions datafusion-cli/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions datafusion/sql/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ unicode_expressions = []
[dependencies]
arrow = { workspace = true }
arrow-schema = { workspace = true }
chrono = { workspace = true }
Copy link
Contributor Author

@devinjdangelo devinjdangelo Mar 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we are sensitive to new dependencies so wanted to flag this proposed addition to datafusion-sql @alamb ...

It is used in this PR to facilitate converting arrow Date types to a formatted string which can be placed in a SQL expression like CAST('2024-01-01' to DATE)

Copy link
Contributor Author

@devinjdangelo devinjdangelo Mar 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be a good solution to put the unparser behind a feature flag and then any unparser specific dependencies can only be enabled if one needs unparser support.

Copy link
Contributor

@alamb alamb Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think arrow already depends on chrono so this change doesn't add any new actual dependency (just an explicit one)

Copy link
Contributor Author

@devinjdangelo devinjdangelo Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and put unparser behind a (default) feature flag anyway. Could come in handy if we need a more invasive dependency later or someone just does not want this functionality.

datafusion-common = { workspace = true, default-features = true }
datafusion-expr = { workspace = true }
log = { workspace = true }
Expand Down
Loading