Skip to content

Use setup-macos-aarch64-builder for aarch64 CI pipeline #9242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
viirya merged 1 commit into from
Feb 15, 2024
Merged

Use setup-macos-aarch64-builder for aarch64 CI pipeline #9242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ jobs:
with:
submodules: true
- name: Setup Rust toolchain
uses: ./.github/actions/setup-macos-builder
uses: ./.github/actions/setup-macos-aarch64-builder
Copy link
Contributor

@comphead comphead Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove ./.github/actions/setup-macos-builder ?

Copy link
Contributor

@comphead comphead Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: my bad this change for aarch64 only

Copy link
Member Author

@viirya viirya Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't point to correct builder in #9191. Although it seems also working. 🤔

- name: Run tests (excluding doctests)
shell: bash
run: |
Expand Down