Use concat to simplify Nested Scalar creation #9174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jayzhan211 <[email protected]>
Signed-off-by: jayzhan211 <[email protected]>
comphead
approved these changes
Feb 9, 2024
Contributor
comphead
left a comment
comphead
left a comment
There was a problem hiding this comment.
lgtm thanks @jayzhan211 I think some time ago it was a comment to use a concat, not sure if for this exact purpose
@Weijun-H cc
6 tasks
Contributor
Perhaps #7893 (comment) |
alamb
approved these changes
Feb 9, 2024
datafusion/common/src/scalar.rs
Outdated
Comment on lines
1498
to
1499
| arrow::compute::concat(arrays.as_slice()) | ||
| .map_err(|e| arrow_datafusion_err!(e))? |
Contributor
There was a problem hiding this comment.
Since there is an automatic conversion from ArrowError to DataFusionError you can do this:
Suggested change
| arrow::compute::concat(arrays.as_slice()) | |
| .map_err(|e| arrow_datafusion_err!(e))? | |
| arrow::compute::concat(arrays.as_slice())? |
I verified that this works locally. However I think the code in this PR just follows the pattern as the reset of this file. I'll make a PR to clean that up
datafusion/common/src/scalar.rs
Outdated
Comment on lines
1504
to
1505
| arrow::compute::concat(arrays.as_slice()) | ||
| .map_err(|e| arrow_datafusion_err!(e))? |
Contributor
There was a problem hiding this comment.
Suggested change
| arrow::compute::concat(arrays.as_slice()) | |
| .map_err(|e| arrow_datafusion_err!(e))? | |
| arrow::compute::concat(arrays.as_slice())? |
Signed-off-by: jayzhan211 <[email protected]>
Contributor
|
Thanks again @jayzhan211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Use concat to simplify Nested Scalar creation
Except FixedsizeList
Closes #9145.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?