[MINOR]: Add check for unnecessary projection #9079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustafasrepo
changed the title
comphead
approved these changes
Jan 31, 2024
Contributor
comphead
left a comment
comphead
left a comment
There was a problem hiding this comment.
lgtm thanks @mustafasrepo
alamb
approved these changes
Jan 31, 2024
Contributor
|
Thanks @comphead and @mustafasrepo and @joroKr21 -- it is a great example of improving the code as a team ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
In the review @joroKr21 pointed a place where we do not check for trivial expression. With this PR, I have moved the code to decide whether a projection is necessary or not to its own function. By this way, we can be more explicit. Inconsistent usages could be decreased.
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?