[pruning] Add shortcut when all units have been pruned #8675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ted-Jiang
commented
Dec 29, 2023
|
|
||
| /// Check all containers has rows that DEFINITELY DO NOT pass the predicate | ||
| fn check_all_pruned(&self) -> bool { | ||
| self.inner.iter().all(|&x| !x) |
Member
Author
There was a problem hiding this comment.
From above
/// One element per container. Each element is
/// * `true`: if the container has row that may pass the predicate
/// * `false`: if the container has rows that DEFINITELY DO NOT pass the predicate
alamb
approved these changes
Dec 29, 2023
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @Ted-Jiang -- I was actually dreaming about this change last night 💤
We can probably add the same basic idea (skip subsequent range analysis) if the guarantees can rule out the row groups in @yahoNanJing PR #8669
7 tasks
Contributor
Actually, upon more thought I think this code will directly apply to #8669 so no additional changes are required ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8676.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?