Skip to content

test: add count distinct group by date_bin #8178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

test: add count distinct group by date_bin #8178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions datafusion/sqllogictest/test_files/groupby.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2278,6 +2278,27 @@ CREATE TABLE exchange_rates (
(3, '2022-01-02 12:00:00'::timestamp, 'TRY', 'USD', 0.11),
(4, '2022-01-03 10:00:00'::timestamp, 'EUR', 'USD', 1.12)

# test count and count distinct group by date_bin/date_part
query error
select date_bin(interval '1 minute', ts) as bin, count(distinct currency_from) as count from exchange_rates group by bin;

query error
select date_part('year', ts) as year, count(distinct currency_from) as count from exchange_rates group by year;
Copy link
Contributor Author

@NGA-TRAN NGA-TRAN Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 2 tests should pass after this PR #8176 is merged


query PI
select date_bin(interval '1 minute', ts) as bin, count(currency_from) as count from exchange_rates group by bin;
----
2022-01-01T06:00:00 1
2022-01-01T08:00:00 1
2022-01-01T11:30:00 1
2022-01-02T12:00:00 1
2022-01-03T10:00:00 1

query RI
select date_part('year', ts) as year, count(currency_from) as count from exchange_rates group by year;
----
2022 5

# test_ordering_sensitive_aggregation
# ordering sensitive requirement should add a SortExec in the final plan. To satisfy amount ASC
# in the aggregation
Expand Down