Use datum arithmetic scalar value #7375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
physical-expr
tustvold
commented
Aug 22, 2023
| /// | ||
| /// NB: operating on `ScalarValue` directly is not efficient, performance sensitive code | ||
| /// should instead make use of vectorized array kernels | ||
| pub fn add<T: Borrow<ScalarValue>>(&self, other: T) -> Result<ScalarValue> { |
Contributor
Author
There was a problem hiding this comment.
The performance of this is likely worse, however, following #7358 the only use of this logic is within the range analysis framework, the median accumulator (to average two values in the event of an even number), and Range window functions, none of which I would consider performance critical
Contributor
Author
|
#7376 should resolve the median issue |
tustvold
force-pushed
the
use-datum-arithmetic-scalar-value
branch
from
5064a79 to
86b4453
Compare
github-actions
bot
removed
optimizer
tustvold
force-pushed
the
use-datum-arithmetic-scalar-value
branch
from
86b4453 to
4bc82e5
Compare
alamb
approved these changes
Aug 23, 2023
|
|
||
| /// Wrapping addition of `ScalarValue` | ||
| /// | ||
| /// NB: operating on `ScalarValue` directly is not efficient, performance sensitive code |
Contributor
There was a problem hiding this comment.
I like the performance admonition 👍
Contributor
These are all bug fixes in my mind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #7353
Rationale for this change
This avoids duplicated arithmetic logic, and moves us closer to replacing the custom ScalarValue logic with upstream kernels (#7353)
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
The upstream kernels have a couple of differences compared to the existing impls: