Skip to content

Conversation

@waitingkuo
Copy link
Contributor

Which issue does this PR close?

Closes #3071

Rationale for this change

keep up with dependencies

#2867 and #3037 need sqlparser v0.20.0

What changes are included in this PR?

NestedJoin now support alias

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner labels Aug 8, 2022
@waitingkuo waitingkuo marked this pull request as ready for review August 8, 2022 09:06
@codecov-commenter
Copy link

Codecov Report

Merging #3072 (8640e8b) into master (0e0931d) will increase coverage by 0.00%.
The diff coverage is 84.21%.

@@           Coverage Diff           @@
##           master    #3072   +/-   ##
=======================================
  Coverage   85.85%   85.85%           
=======================================
  Files         289      289           
  Lines       51890    51907   +17     
=======================================
+ Hits        44548    44567   +19     
+ Misses       7342     7340    -2     
Impacted Files Coverage Δ
datafusion/sql/src/planner.rs 82.02% <40.00%> (+0.07%) ⬆️
datafusion/core/tests/sql/joins.rs 99.33% <100.00%> (+0.01%) ⬆️
datafusion/core/src/physical_plan/metrics/value.rs 87.43% <0.00%> (+0.50%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@alamb
Copy link
Contributor

alamb commented Aug 8, 2022

Thanks @waitingkuo

@alamb alamb merged commit acd1f40 into apache:master Aug 8, 2022
@ursabot
Copy link

ursabot commented Aug 8, 2022

Benchmark runs are scheduled for baseline = 68b205f and contender = acd1f40. acd1f40 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants