Skip to content

Conversation

@feniljain
Copy link
Contributor

Which issue does this PR close?

Rationale for this change

Explained in issue

What changes are included in this PR?

Implement baseline metrics for AsyncFuncExec operator

Are these changes tested?

Have added a test with PR

Are there any user-facing changes?

There are user facing changes, now explain analyze will show metrics of AsyncFuncExec too, do we need to update any documentation regarding this? Asking cause I couldn't find anything on a quick search.

@github-actions github-actions bot added core Core DataFusion crate physical-plan Changes to the physical-plan crate labels Jan 3, 2026
@2010YOUY01
Copy link
Contributor

There are user facing changes, now explain analyze will show metrics of AsyncFuncExec too, do we need to update any documentation regarding this? Asking cause I couldn't find anything on a quick search.

Here is the doc for metrics https://datafusion.apache.org/user-guide/metrics.html
But we don't have to update it, since BaselineMetrics is already documented.

@feniljain
Copy link
Contributor Author

Yup, had the same thought for BaselineMetrics documentation, thanks for the clarification! 🙇🏻

Copy link
Contributor

@2010YOUY01 2010YOUY01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@2010YOUY01 2010YOUY01 added this pull request to the merge queue Jan 7, 2026
Merged via the queue into apache:main with commit 1f654bb Jan 7, 2026
32 checks passed
@feniljain feniljain deleted the feat-async-func-metrics branch January 7, 2026 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate physical-plan Changes to the physical-plan crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement metrics for AsyncFuncExec

3 participants